Skip to content

fix(tracing): apiName calculation for route handlers #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2022
Merged

fix(tracing): apiName calculation for route handlers #1409

merged 1 commit into from
Jul 6, 2022

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Jul 5, 2022 •
edited
Loading

Fixes #1397

@mxschmitt mxschmitt marked this pull request as ready for review July 5, 2022 20:21
@mxschmitt mxschmitt force-pushed the fix-tracing-api-name branch from c19d226 to a411c69 Compare July 5, 2022 20:49
@mxschmitt mxschmitt marked this pull request as draft July 5, 2022 21:41
@mxschmitt
Copy link
Member Author

Back to draft, covering it with more tests tomorrow and fixing more spotted bugs.

@mxschmitt mxschmitt force-pushed the fix-tracing-api-name branch from a411c69 to 09b8aeb Compare July 6, 2022 12:45
@mxschmitt mxschmitt marked this pull request as ready for review July 6, 2022 12:46
@mxschmitt mxschmitt merged commit 8820f30 into microsoft:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rwoll rwoll rwoll approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Page.continue_ and friends does not yield to expected apiName for trace viewer
2 participants
@mxschmitt @rwoll